Skip to content

Commit

Permalink
Drop distribution table (#56)
Browse files Browse the repository at this point in the history
  • Loading branch information
dianaclarke committed May 13, 2021
1 parent 70cecd3 commit 8b3726b
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 964 deletions.
136 changes: 0 additions & 136 deletions conbench/entities/distribution.py

This file was deleted.

3 changes: 0 additions & 3 deletions conbench/entities/summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from ..entities.context import Context
from ..entities.commit import Commit, parse_commit
from ..entities.data import Data
from ..entities.distribution import update_distribution
from ..entities.machine import Machine, MachineSchema
from ..entities.run import Run
from ..entities.time import Time
Expand Down Expand Up @@ -149,8 +148,6 @@ def create(data):
bulk.append(Time(result=x, summary_id=summary.id, iteration=i + 1))
Time.bulk_save_objects(bulk)

update_distribution(repository, sha, summary, 1000)

return summary


Expand Down
55 changes: 0 additions & 55 deletions conbench/tests/api/test_benchmarks.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import copy
import decimal
import uuid

import pytest

from ...api._examples import _api_benchmark_entity
from ...entities._entity import NotFound
from ...entities.distribution import Distribution
from ...entities.summary import Summary
from ...tests.api import _asserts

Expand Down Expand Up @@ -235,55 +232,3 @@ def test_nested_schema_validation(self, client):
},
}
self.assert_400_bad_request(response, message)

def test_create_benchmark_distribution(self, client):
self.authenticate(client)
data = copy.deepcopy(self.valid_payload)
data["tags"]["name"] = uuid.uuid4().hex

# first result
response = client.post("/api/benchmarks/", json=data)
new_id = response.json["id"]
summary_1 = Summary.one(id=new_id)
location = "http://localhost/api/benchmarks/%s/" % new_id
self.assert_201_created(response, _expected_entity(summary_1), location)
case_id = summary_1.case_id

# after one result
distributions = Distribution.search(filters=[Distribution.case_id == case_id])
assert len(distributions) == 1
assert distributions[0].unit == "s"
assert distributions[0].observations == 1
assert distributions[0].mean_mean == decimal.Decimal("0.03636900000000000000")
assert distributions[0].mean_sd is None
assert distributions[0].min_mean == decimal.Decimal("0.00473300000000000000")
assert distributions[0].min_sd is None
assert distributions[0].max_mean == decimal.Decimal("0.14889600000000000000")
assert distributions[0].max_sd is None
assert distributions[0].median_mean == decimal.Decimal("0.00898800000000000000")
assert distributions[0].median_sd is None

# second result
response = client.post("/api/benchmarks/", json=data)
new_id = response.json["id"]
summary_2 = Summary.one(id=new_id)
location = "http://localhost/api/benchmarks/%s/" % new_id
self.assert_201_created(response, _expected_entity(summary_2), location)
assert summary_1.case_id == summary_2.case_id
assert summary_1.context_id == summary_2.context_id
assert summary_1.machine_id == summary_2.machine_id
assert summary_1.run.commit_id == summary_2.run.commit_id

# after two results
distributions = Distribution.search(filters=[Distribution.case_id == case_id])
assert len(distributions) == 1
assert distributions[0].unit == "s"
assert distributions[0].observations == 2
assert distributions[0].mean_mean == decimal.Decimal("0.03636900000000000000")
assert distributions[0].mean_sd == decimal.Decimal("0")
assert distributions[0].min_mean == decimal.Decimal("0.00473300000000000000")
assert distributions[0].min_sd == decimal.Decimal("0")
assert distributions[0].max_mean == decimal.Decimal("0.14889600000000000000")
assert distributions[0].max_sd == decimal.Decimal("0")
assert distributions[0].median_mean == decimal.Decimal("0.00898800000000000000")
assert distributions[0].median_sd == decimal.Decimal("0")

0 comments on commit 8b3726b

Please sign in to comment.