Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URSA-253 > Do not expect author field to contain author info in Github /commits/id response and do not try requests with 500 responses #17

Merged
merged 3 commits into from
Mar 15, 2021

Conversation

ElenaHenderson
Copy link
Collaborator

@ElenaHenderson ElenaHenderson commented Mar 15, 2021

This PR:

  • removes 500 responses from being retried when POST /api/benchmarks/ requests get 500 errors. BK builds time out (we have a 2 hour time out for BK builds) when we retry 500s.
  • updates parse_commit to not expect author field to contain any author info in Github's GET https://api.github.com/repos/apache/arrow/commits/id response.

GET https://api.github.com/repos/apache/arrow/commits/id response sometimes has author = None. This is somewhat intermittent behavior. I could not find any explanation for this but Github API users run into this issue.

Here is an example of a response like this:

Screen Shot 2021-03-15 at 12 22 38 PM

…and do not try requests with 500 responses
@ElenaHenderson ElenaHenderson merged commit f8143ef into main Mar 15, 2021
@ElenaHenderson ElenaHenderson deleted the URSA-253-do-not-expect-author-in-github-response branch March 15, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant