New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.0 don't show done/next button in only one step #1101
Comments
Could you give me some kind of solution? I've had the case open for 12 days and I have no way of showing the DONE BUTTON. |
Same problem here.
|
Exactly @ZsharE . Even on your website this happens. |
https://github.com/usablica/intro.js/blob/master/src/core/showElement.js#L380 Should be: |
It works perfectly! |
Sorry about that that folks, could you please test this PR #1118 -- happy to release a version as soon as that's approved. |
cc @DigitalAndSEO and @ZsharE |
there is also a Netlify dev preview https://deploy-preview-1118--introjs-repo.netlify.app/example/ for that PR |
Test & Work, but now appears the back button, even if I have
Screen: https://jmp.sh/R4Bti0h |
@DigitalAndSEO I'm guessing that's because you've changed "line 2867" to
I cannot reproduce that bug. |
That's. If instead of "> =" I leave the original ">" it doesn't work, because there is only one step. ORIGINAL 3.1.0 (don't work): |
@DigitalAndSEO not sure if I follow. if you open https://deploy-preview-1118--introjs-repo.netlify.app/example/hello-world/index.html and run the following code: introJs().setOptions({
steps: [{
intro: "Some test message here."
}]
}).start(); in your Dev console, you'll only see the "Done" button with no "Previous" button because there is only one step. |
Tested, works fine now. 👍 |
Will you upload it to CDNs as a new 3.1.1 update? |
Just published v3.2.0 https://github.com/usablica/intro.js/releases/tag/v3.2.0 |
You will also publish the changes in https://cdnjs.com/libraries/intro.js ? |
CDNs are update automatically from our NPM package, see https://www.jsdelivr.com/package/npm/intro.js not sure how long it takes to see the changes on cdnjs. |
I have tried all possible combinations of "show buttons", "nextToDone", etc ...
And when there is only one step, it does not show any type of button.
HTML RESULT: https://jmp.sh/lQNnE2V
SCREEN RESULT: https://jmp.sh/vXeDyX1
The text was updated successfully, but these errors were encountered: