New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does require('intro.js') export an object with just introJs? #581

Closed

ibc opened this issue May 19, 2016 · 1 comment

ibc commented May 19, 2016 •

edited

var introJs = require('intro.js');

console.log(introJs);

output:

Object { introJs: function(targetElm) }

This has little sense. Why doesn't require('intro.js') directly export the introJs function instead?

So, instead of exports.introJs = introJs; this would be much better to check for window.module and export module.exports = introJs.

The text was updated successfully, but these errors were encountered:

odedniv commented Jun 21, 2016

Oh wow I was trying to figure this out for an hour now...
+1

bozdoz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment