Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how road event positional accuracy is described #233

Closed
j-d-b opened this issue Jan 20, 2022 · 2 comments
Closed

Refactor how road event positional accuracy is described #233

j-d-b opened this issue Jan 20, 2022 · 2 comments
Assignees
Labels
Refactor This item related to refactoring the specification.

Comments

@j-d-b
Copy link
Collaborator

j-d-b commented Jan 20, 2022

This issue is related to #201, #213, and #232.

Background

Currently, the properties for describing positional accuracy of a road event—that is, the "accuracy" of coordinates of a RoadEventFeature's geometry—occur directly on the WorkZoneRoadEvent (the only type of road event where they are currently used). There are two properties related to positional accuracy, beginning_accuracy and ending_accuracy, but could be more in the future to allow representing the accuracy of intermediate points (see #232) or the measured accuracy of the coordinates as a distance (see #201).

Since these properties are defined only on the WorkZoneRoadEvent, if there was desire to add them to another type of road event, such as the DetourRoadEvent, they would have to be duplicated there—any changes in the future would have to be made in two places, which is error prone and inelegant.

Proposal

All properties related to positional (or "spatial") accuracy could occur on a new PositionalAccuracy object. The PositionalAccuracy object would be used by the WorkZoneRoadEvent and in the future any other objects that need to describe positional accuracy. In addition, expansions to what positional accuracy defines can be represented would be added to this object.

PositionalAccuracy Object

The PositionalAccuracy object describes the accuracy of geographical coordinates.

Properties

Name Type Description Conformance Notes
beginning_accuracy SpatialVerification Indicates how the beginning coordinate was defined. Required
ending_accuracy SpatialVerification Indicates how the ending coordinate was defined. Required

Used By

Property Object
positional_accuracy WorkZoneRoadEvent

Note that the above implementation just moves the beginning_accuracy and ending_accuracy properties to the PositionalAccuracy object. However, i think it would be cleaner to also implement the approach in #213

@j-d-b j-d-b added Data-content Refactor This item related to refactoring the specification. labels Jan 20, 2022
@mark-mockett mark-mockett added this to the v4.1 milestone Feb 14, 2022
@j-d-b j-d-b self-assigned this Mar 22, 2022
@j-d-b j-d-b modified the milestone: v4.1 Mar 23, 2022
@j-d-b j-d-b removed this from the v4.1 milestone Mar 31, 2022
@j-d-b
Copy link
Collaborator Author

j-d-b commented Mar 31, 2022

Deferred as there needs to be more discussion regarding other verification/accuracy properties that would be beneficial to make it worthwhile to create a separate object.

@j-d-b
Copy link
Collaborator Author

j-d-b commented Sep 19, 2022

Closing until more descriptive location accuracy is desired.

@j-d-b j-d-b closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor This item related to refactoring the specification.
Projects
None yet
Development

No branches or pull requests

2 participants