Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update empty consent and persist initial state #21

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

edgarlr
Copy link
Contributor

@edgarlr edgarlr commented Feb 23, 2022

fixes #19

@edgarlr
Copy link
Contributor Author

edgarlr commented Feb 23, 2022

@bring-shrubbery Hey, I added the change we talked about the other day, let me know your thoughts or if you have a different approach in mind and I can update it!

src/constants.ts Outdated Show resolved Hide resolved
src/useCookieConsent.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #21 (ae53f63) into main (96f125b) will decrease coverage by 1.64%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   93.47%   91.83%   -1.65%     
==========================================
  Files           3        3              
  Lines          46       49       +3     
  Branches       14       16       +2     
==========================================
+ Hits           43       45       +2     
- Misses          3        4       +1     
Impacted Files Coverage Δ
src/useCookieConsent.ts 89.18% <85.71%> (-1.99%) ⬇️
src/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f125b...ae53f63. Read the comment docs.

@bring-shrubbery bring-shrubbery merged commit d94247d into bring-shrubbery:main Mar 8, 2022
@bring-shrubbery
Copy link
Owner

Thanks for the PR @edgarlr!

I've released this PR under version v0.3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Necessary cookies are not always set to true
3 participants