Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AcceptCookiesOptions to acceptCookies in types #26

Merged
merged 2 commits into from
Apr 1, 2022
Merged

add AcceptCookiesOptions to acceptCookies in types #26

merged 2 commits into from
Apr 1, 2022

Conversation

MonstraG
Copy link
Contributor

@MonstraG MonstraG commented Apr 1, 2022

Fixes #25

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #26 (e77dcf7) into main (12c0cba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           3        3           
  Lines          49       49           
  Branches       16       16           
=======================================
  Hits           45       45           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c0cba...e77dcf7. Read the comment docs.

Copy link
Owner

@bring-shrubbery bring-shrubbery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@bring-shrubbery bring-shrubbery merged commit f8e8d9e into bring-shrubbery:main Apr 1, 2022
@bring-shrubbery
Copy link
Owner

@MonstraG I've released this PR to npm under v0.3.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowChangingNecessary missing from the typedefs for acceptCookies function
3 participants