Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration of the static buffer size #1285

Closed
SkymanOne opened this issue Aug 18, 2023 · 0 comments · Fixed by #1310
Closed

Support configuration of the static buffer size #1285

SkymanOne opened this issue Aug 18, 2023 · 0 comments · Fixed by #1310
Assignees

Comments

@SkymanOne
Copy link
Contributor

Feat to the use-ink/ink#1869

We should support the configuration of the static buffer size via the environment variable. However, every time the value changes ink_env crate needs to be rebuilt. We can detect the change by inspecting metadata (when use-ink/ink#1879 gets completed) and comparing to the value set in the environment. If they differ then we can run cargo clean -p ink_env && cargo build to rebuild the crate and inject the new value.

Due to limited memory allocated for each contract execution, we should also warn a user if they try to deploy a contract with a too-large buffer size (see use-ink/ink#1471 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant