Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable skipping linting step #449

Closed
cmichi opened this issue Mar 2, 2022 · 3 comments · Fixed by #468
Closed

Enable skipping linting step #449

cmichi opened this issue Mar 2, 2022 · 3 comments · Fixed by #468
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cmichi
Copy link
Collaborator

cmichi commented Mar 2, 2022

From #431 (comment):

Also maybe make dylint configurable? For example, I don't want to build it during integration tests=)

We should add a flag --no-linting or something like that to skip the linter.

@cmichi cmichi added enhancement New feature or request good first issue Good for newcomers labels Mar 2, 2022
@xgreenx
Copy link
Collaborator

xgreenx commented Mar 17, 2022

It is veeeeery critical task=D Our integration tests now take 1h to build it when previously it was ~10 min. When do you plan to add that? If you are okay with --no-linting I will implement it=)

@cmichi
Copy link
Collaborator Author

cmichi commented Mar 17, 2022

It is veeeeery critical task=D Our integration tests now take 1h to build it when previously it was ~10 min.

Oh oh, we don't observe the same in our CI. Do you have a link to your CI configuration?

We should really prioritize #450 then.

If you are okay with --no-linting I will implement it=)

Yeah totally!

@xgreenx
Copy link
Collaborator

xgreenx commented Mar 17, 2022

We are using Redspot to build and run all integration tests. It builds each contract from the scratch in the temp folder. We are using CARGO_TARGET_DIR to reuse previous built artifacts. But while #450 is not implemented it builds linting each time for each contract. We have 33 contracts=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants