Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Save Changes to request #142

Open
helloanoop opened this issue Mar 29, 2023 · 9 comments
Open

Auto Save Changes to request #142

helloanoop opened this issue Mar 29, 2023 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@helloanoop
Copy link
Contributor

Currently Bruno does not auto save changes made to the request to the file unless user explicitly saves it by pressing Ctrl/Cmd+S

Some of our users prefer auto-save functionality (Similar to IntelliJ editor)
I am thinking of supporting this via a UI toggle in app settings.

@stratosgear
Copy link

Well, eventually I "figured it" out that there must be some way to save the edits in the requests tab when i was desperately trying to get the changes persisted. I was looking for a File/Save option or something, until eventually tried a CTRL+S randomly in the blind. That was a very confusing experience.

To be more precise Bruno 0.19.0 still does not persist URL changes to requests....

@gjrivero
Copy link

gjrivero commented Oct 5, 2023

There should be some label indicating how to save the request. I had to search the forum to find out that the command was Ctrl-S

@helloanoop
Copy link
Contributor Author

We have heard this from multiple people. And I understand this is frustrating to lose data that you though you had saved.

We can make auto-save the default and provide a toggle in the app preferences to turn auto toggle off.

@helloanoop helloanoop added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 5, 2023
@helloanoop
Copy link
Contributor Author

Another option is to provide a "Save" button for now next to the send icon

image

Can someone in the community help with this?

@srikary12
Copy link

@helloanoop Do we need toggle to auto save tests?

@helloanoop
Copy link
Contributor Author

@srikary12 I published a patch in v0.21.1 that introduces several nudges to indicate that they need to save the request.
We also show a popup when a user attempts to close a request without saving.

Do we need toggle to auto save tests?

Our current implementation basically saves the request draft inside the local redux store. It only gets written to the filesystem, when we save Cmd+s/Ctrl+S or the newly introduced save button in the url bar.

image

We definitely want to support Auto-Save Toggle for users who prefer auto save - This is will be taken in v2.
Platform stability and other features in roadmap are priority for v1

@srikary12
Copy link

@helloanoop I've started working on this, Can expect a PR before weekend.

@srikary12
Copy link

@helloanoop raised a PR. Please let me know if something needs to be improved :).

@MSGoodman
Copy link

Just adding my two cents here: although I think auto-saving as implemented in the PR above (every X seconds) is a great feature, I would personally rather have the option for a different sort of auto-saving, where my request is saved whenever I send it. Probably a totally different feature and maybe one other folks wouldn't want, just sharing my own thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants