Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: OAuth2 Authorization Code Flow fails for intermediate redirects #1778

Closed
layereight opened this issue Mar 12, 2024 · 2 comments · Fixed by #1777
Closed

BUG: OAuth2 Authorization Code Flow fails for intermediate redirects #1778

layereight opened this issue Mar 12, 2024 · 2 comments · Fixed by #1777

Comments

@layereight
Copy link
Contributor

layereight commented Mar 12, 2024

The authorization process will fail for authorization servers offering a "multi-step" authorization that include intemediate redirects casually containing the keyword code in their uri.

I happen to use an authorization server that guides the user through several forms (connected through intemediate redirects) during the authorization process. One of the intermediate redirect casually contains code in the uri (but not as the distinct query parameter). Thus the authorization code flow fails with the following error trace:

Error occurred in handler for 'send-http-request': Error: Invalid Callback Url
    at onWindowRedirect (~/devel/bruno/packages/bruno-electron/out/linux-unpacked/resources/app.asar/src/ipc/network/authorize-user-in-window.js:30:18)
    at EventEmitter.didNavigateListener (~/devel/bruno/packages/bruno-electron/out/linux-unpacked/resources/app.asar/src/ipc/network/authorize-user-in-window.js:67:7)
    at EventEmitter.emit (node:events:527:28)
@layereight layereight changed the title OAuth2 Authorization Code Flow fails for intermediate redirects BUG: OAuth2 Authorization Code Flow fails for intermediate redirects Mar 14, 2024
@layereight
Copy link
Contributor Author

The issue still exists with release 1.11.0

@ThomasPilot
Copy link

The issue still exists with release 1.11.0

Can confirm this, same issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants