Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table component needs number formatting #47

Closed
dannyvankooten opened this issue Jun 1, 2018 · 4 comments
Closed

Table component needs number formatting #47

dannyvankooten opened this issue Jun 1, 2018 · 4 comments

Comments

@dannyvankooten
Copy link
Contributor

Larger numbers in the table component should be formatted like so: xx,xxx.

image

@pjrvs
Copy link
Collaborator

pjrvs commented Jun 1, 2018

My vote: large numbers are formatted to never be more than 4 chrs including decimal place (but not including commas).

examples:

1,865
18.4k
99.8m
525

@ziburski
Copy link

ziburski commented Jun 1, 2018

My vote: large numbers are formatted to never be more than 4 chrs including decimal place (but not including commas).

Hey @pjrvs, that’s a great idea! Maybe you could even do a cutoff, so that all numbers are in the same format? So if you have one number that’s 18.4k, it’s also 7.21k and 0.18k? Just a thought, since different formats make scanning difficult.

And on the topic of formatting numbers for easy scanning, you could look into tabular figures. Might be tricky to implement if the font doesn’t support it though.

@pjrvs
Copy link
Collaborator

pjrvs commented Jun 1, 2018

i agree on format mostly but 0.18k is less detail than 1834 and both have 4 characters so why not go with the latter as it's more accurate? i think big numbers need truncating for sure, but smaller numbers can be accurate.

@ziburski
Copy link

ziburski commented Jun 1, 2018

Fair enough. Your example list with four different formats just overwhelmed me a little, since you have to go through every character of every number to figure out which is highest. It likely works out better with real data and sorting though. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants