Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide sorting options #12

Closed
stdedos opened this issue Feb 25, 2021 · 3 comments
Closed

Provide sorting options #12

stdedos opened this issue Feb 25, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@stdedos
Copy link

stdedos commented Feb 25, 2021

Hello there! Thank you for a fantastic addition to Github!
It is making life so much easier than doing it with shell magic and parsing the DOM ...
With that being said:

I am mostly interested on the projects that have the most modifications. And I can imagine different people might want to try different things based on different criteria.

Exposing more of the sorting options would be a nice addition to this nifty tool!

@payne911
Copy link
Collaborator

I am mostly interested on the projects that have the most modifications. And I can imagine different people might want to different things based on different criteria.

Fair point, and I have considered it myself as well. However, this would quickly grow rather complex, not to mention all the UI work (which is my weakness) that would need to be done to enable the additional logic.

Maybe a list of the settings you had in mind could help narrow down on the specific needs of the community ?

Moreover, if you have the time and motivation for it, feel absolutely free to contribute a PoC : I will gladly review your PR. :)

@payne911 payne911 added the enhancement New feature or request label Feb 25, 2021
@stdedos
Copy link
Author

stdedos commented Feb 25, 2021

I have promised (the few time that I spare) to other open sources already; but be sure I'll round-robin to this one.

I have anyway cloned the project locally 😀

@payne911
Copy link
Collaborator

payne911 commented Mar 8, 2021

I'm thinking useful-forks could at least provide customization for deciding how many commits should be used to filter out based on ahead_by and behind_by.

There are too many instances where some forks are displayed just because someone added a merge commit on the default branch (master or main), for example. The same goes for forks which are thousands of commits behind (although that doesn't necessarily mean the fork doesn't contain some interesting additional content).

@useful-forks useful-forks locked and limited conversation to collaborators Mar 15, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants