Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: merged pull reqests into qbittorrent-nox-staticish-mk2.sh #17

Closed
userdocs opened this issue Oct 1, 2020 · 5 comments
Closed

Comments

@userdocs
Copy link
Owner

userdocs commented Oct 1, 2020

@IceCodeNew please take a look at this script

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh

I have added most of the ideas you presented but in slightly different ways,

Contributor credit

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L9

Since the pull requests are closed and have overlapping i'll credit you this way?

Download and delete functions

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L245#L294

This is what i wanted to do before merging the ideas. Now there are two functions to manage instead of many commands. They are here now making relevant changes is easier.

better git commands, why?

I tested this and in the default mode where boost was downloaded from bintray the overall transfer of the script was 230M and the git commands make little difference. The problem occurred when this boost archive was unavailable and the script defaulted to boost from github. it then became 1250M. Using the the better boost commands the transfer is consistently 230M with either method but may take longer to complete when downloading boost from github.

curl flags

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L244

I have only used to for the main functions and not he url variables for now. but this is the idea.

proxy support

No system modifications. Specific to the script

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L49#L51
https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L244
https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L266

new flag

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L45

This is to use the qbittorrent master and/or libtorrent main branch (RC_1_2) when building.

Testing

Try it out and let me know if it manages to merged the changes you were contributing.

@IceCodeNew
Copy link
Contributor

IceCodeNew commented Oct 2, 2020

Thanks for your work!

Since the pull requests are closed and have overlapping i'll credit you this way?

I appreciate that. ;-)

@IceCodeNew
Copy link
Contributor

IceCodeNew commented Oct 2, 2020

curl flags

https://github.com/userdocs/qbittorrent-nox-static/blob/master/qbittorrent-nox-staticish-mk2.sh#L244

I have only used to for the main functions and not he url variables for now. but this is the idea.

This idea actually works, though I'd suggest introducing curl as a function, like this:

curl() {
  $(type -P curl) -sSLNq --connect-timeout 5 --retry 5 --retry-delay 10 --retry-max-time 60 ${CURL_PROXY} "$@"
}

#18

@IceCodeNew
Copy link
Contributor

The problem occurred when this boost archive was unavailable and the script defaulted to boost from github. it then became 1250M. Using the the better boost commands the transfer is consistently 230M with either method but may take longer to complete when downloading boost from github.

Cool.

@userdocs
Copy link
Owner Author

userdocs commented Oct 2, 2020

Ok so i merged and pushed some changes.

@userdocs
Copy link
Owner Author

userdocs commented Oct 5, 2020

ok, everything is now updated and pushed. closed but not locked.

@userdocs userdocs closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants