Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitizers to register.json #574

Closed
lcharette opened this issue Jul 13, 2016 · 5 comments
Closed

Add sanitizers to register.json #574

lcharette opened this issue Jul 13, 2016 · 5 comments
Labels
confirmed bug Something isn't working todo Generic task

Comments

@lcharette
Copy link
Member

As discussed on chat, "sanitizers" : { "raw" : {}} needs to be added to register.json scheme to match user-create.json scheme. Will fix weird behavior when a ' is used in user_name.

(I can't create pull request right now as I already have one open in the master branch of my fork)

@alexweissman
Copy link
Member

Yes, sounds good as a hotfix. For others finding this issue, please note that sanitizers as a whole are deprecated in Fortress v2. Instead, we will support optional data transformations.

@Netrilix
Copy link
Contributor

Netrilix commented Jul 15, 2016

This also covers login.json. As it stands, register.json and login.json match eachother, so logins are possible. Users created by the admin control panel (user-create.json), however, will not be able to log in if they have HTML entities in their username. Any fix should include an upgrade of previous usernames to the proper format.

@Netrilix
Copy link
Contributor

As discussed in chat, there are two options:

  • Upgrade users as they log in
  • Upgrade all users if their database version is less than the version this fix is added in

@Netrilix Netrilix added the confirmed bug Something isn't working label Jul 15, 2016
@alexweissman alexweissman modified the milestone: 0.3.1.20 Hotfix Aug 20, 2016
@alexweissman
Copy link
Member

Any update on fixing this in 0.3.1?

@alexweissman alexweissman removed this from the 0.3.1.20 Hotfix milestone Dec 20, 2016
@alexweissman alexweissman added the todo Generic task label Dec 20, 2016
@alexweissman
Copy link
Member

If someone runs into this problem and wants to do a PR for a fix, feel free to re-open this issue. Otherwise, I suggest we concentrate our efforts on V4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working todo Generic task
Projects
None yet
Development

No branches or pull requests

3 participants