Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mariadb support #117

Closed
rkanagaraj opened this issue Sep 12, 2022 · 8 comments
Closed

mariadb support #117

rkanagaraj opened this issue Sep 12, 2022 · 8 comments
Labels
big A big feature help wanted We would appreciate PR

Comments

@rkanagaraj
Copy link

Is there a plan to add mariadb support in future..

@apolukhin apolukhin added enhancement help wanted We would appreciate PR labels Sep 12, 2022
@apolukhin
Copy link
Member

Related to the #14

@rkanagaraj
Copy link
Author

Related to the #14

@apolukhin apolukhin reopened this Oct 25, 2022
@apolukhin
Copy link
Member

MariaDB does support an async API, and that it does also support bulk transactions in the C connector.

https://kb-mirror.mariadb.com/kb/en/non-blocking-client-library/

@apolukhin apolukhin added big A big feature and removed enhancement labels Oct 25, 2022
@itrofimow
Copy link
Contributor

There is https://github.com/mariadb-corporation/mariadb-connector-c which supports async operation, but it's LGPL licensed, so we can't vendor it, right?

@itrofimow
Copy link
Contributor

... but it's LGPL licensed, so we can't vendor it, right?

Sadly it's LGPL 2.1 licensed, so we can't even link it dynamically. Seems to me that we are out of luck here @apolukhin

@Jihadist
Copy link
Contributor

Jihadist commented Jan 9, 2023

@itrofimow looks like you wanna implement mysql specific driver. Why did you decide to implement a specific driver instead of the most common odbc driver that can be used across dbms? For example, one odbc driver with small modifications can be used with mysql, oracle, ibm db and mssql.

@itrofimow
Copy link
Contributor

Honestly i just didn't think about ODBC at all at the time, that's mostly it)

Right now i also see a couple of points against that:

  1. It gets very complicated and time consuming to test the driver against many database implementations - infrastructure isn't quite there (for example i'll have to sneak some ugly bash into testsuite to support 3 different MySQL and friends installations).
  2. With MySQL being potentially very popular it makes sense to have an optimized driver for that DB specifically
  3. Maintaining general purpose ODBC implementation might quickly become overwhelming with all the potential issues coming from interaction with different DB backends, for which i likely just won't have enough time/will

@itrofimow
Copy link
Contributor

We just merged MySQL/MariaDB driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big A big feature help wanted We would appreciate PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants