Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stories do not have external_links typed #86

Closed
hdavidzhu opened this issue Nov 18, 2020 · 2 comments · Fixed by #93
Closed

Stories do not have external_links typed #86

hdavidzhu opened this issue Nov 18, 2020 · 2 comments · Fixed by #93

Comments

@hdavidzhu
Copy link

https://github.com/clubhouse/clubhouse-lib/blob/d85c11de5156a2e4f93f7cf44412b09fb9693e38/src/types.ts#L346

This schema is out-of-date.
@charpeni
Copy link
Member

Thanks for flagging this!

Replacing external_tickets with external_links is one of my upcoming tasks.

@charpeni charpeni mentioned this issue Mar 1, 2021
Merged
@charpeni
Copy link
Member

charpeni commented Mar 1, 2021

Released as part of clubhouse-lib@0.11.0.

@hdavidzhu hdavidzhu mentioned this issue May 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add external_links to Story type useshortcut/shortcut-client-js
2 participants
@hdavidzhu @charpeni