Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test report is missing failed test lists #1946

Closed
DavyLandman opened this issue May 15, 2024 · 4 comments
Closed

Test report is missing failed test lists #1946

DavyLandman opened this issue May 15, 2024 · 4 comments
Labels

Comments

@DavyLandman
Copy link
Member

image

At least on windows, I get no output about which tests failed.

@DavyLandman
Copy link
Member Author

On windows, this is printed:

rascal>test bool x() = false;
bool (): function(|prompt:///|(0,22,<1,0>,<1,22>))
rascal>:test










☑ Testing $shell$                                                                                       🕒 0:00:00.060
bool: false
rascal>

on linux:

rascal>test bool x() = false;
bool (): function(|prompt:///|(0,22,<1,0>,<1,22>))
rascal>:test
failure: x @ |prompt:///|(0,22,<1,0>,<1,22>)
Test $shell$::x failed due to
        test returned false



Test report for $shell$
        0/1 tests succeeded
        1/1 tests failed
        0/1 tests threw exceptions
☑ Testing $shell$                                                                                       🕒 0:00:00.034
bool: false
rascal>

@DavyLandman
Copy link
Member Author

DavyLandman commented May 16, 2024

@jurgenvinju is there a possibility the progress bar disables writing of output? I just traced the writes of the test runner, and they seem to write to an outputstream, but the terminal doesn't show anything. (something like disabling echo?)

If I send the output to monitor.warning, it does show up properly.

@DavyLandman
Copy link
Member Author

I had a call with @jurgenvinju it's indeed the TerminalProgressBarMonitor class, that intercepts write call and is most likely swallowing the prints that don't have a newline at the end.

@DavyLandman
Copy link
Member Author

DavyLandman commented May 17, 2024

image

This is the stack, it's written 1 byte at the time. and there we get problems.

If I comment out eraseBars() in write(int) we get output again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants