Test for add and delete #5
Conversation
There was a problem hiding this comment.
Hi @usorfaitheloho,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Linters have no errors ✅.
- Codes are clean ✅.
- PR is very good ✅.
- Readme file full of details ✅.
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| test("Test case 1", () => { | ||
| document.body.innerHTML = | ||
| "<div>" + ' <ul class="todo-list"></ul>' + "</div>"; | ||
|
|
||
| const Test = new TaskCollection(true); | ||
| Test.addTaskToList("TaskTest_1 of Example 1"); | ||
| Test.addTaskToList("TaskTest_1 of Example-2"); | ||
| expect(Test.onSaveList()).not.toBeUndefined(); | ||
| const list = document.querySelectorAll(".todo-list li"); | ||
| expect(list).toHaveLength(2); | ||
| }); |
There was a problem hiding this comment.
- Hello @usorfaitheloho nice job on adding the tests suit but let's make you test more variants, so instead of repeating it let's add another test case with a localStorage to test the stored inputs.
There was a problem hiding this comment.
STATUS: APPROVED 🟢 👏
Hi @usorfaitheloho ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
TO HIGHLIGHT:
- Your project is professional 💯
- Your repo is professional 💯
- Well structured files 💯
- You set up linter files and no errors. 💯
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this milestone we worked on the following:
-Created a unit test file containing the add item and delete item test cases.
-Used Jest inbuilt describe method to group add item and delete item test cases
-Mock functionality for local storage