Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list -part 2 #7

Merged
merged 4 commits into from Mar 3, 2022
Merged

Testing To Do list -part 2 #7

merged 4 commits into from Mar 3, 2022

Conversation

usorfaitheloho
Copy link
Owner

@usorfaitheloho usorfaitheloho commented Mar 3, 2022

  • Use jest framework for testing.
  • Created a unit test file containing the editing the task description,updating an item's 'completed' status and the "Clear all completed" function test cases and Used Jest inbuilt describe method to group.
    -Mock functionality for local storage enabled in Application test mode.
    -Mock the HTML elements to test DOM manipulation functions.

Copy link

@moise10r moise10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @usorfaitheloho,

You did a great job so far 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight 💪🏻

  • No linter errors. ✔️
  • Githubflow was correctly used. ✔️
  • Good commit messages ✔️
  • Good test implementation. ✔️

👍 Good job!

STATUS: CHANGES REQUESTED ♻️

Please Check the comments under the review and make all required changes

  • Kindly, Add a descriptive README file to your project, it will be great to add instructions on how to run your tests. This includes npm install , npm run test

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏 💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @moise10r when you comment so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@SajjadAhmad14 SajjadAhmad14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved ✔️ ✔️ ✔️

Hi team,

Congratulations 🎉 Thank you for implementing all the requirements 🙏

Please go ahead and merge the branch!

Happy Coding 👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@usorfaitheloho usorfaitheloho merged commit 5ca3759 into main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants