Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for KMP #176

Open
phillipsk opened this issue Mar 2, 2024 · 8 comments
Open

Support for KMP #176

phillipsk opened this issue Mar 2, 2024 · 8 comments

Comments

@phillipsk
Copy link

Java/Android compose ui tooling library references are preventing the library from being a pure kotlin multiplatform library

@usuiat
Copy link
Owner

usuiat commented Mar 7, 2024

@phillipsk
Thank you for creating an issue.

I am not familiar with KMP, so please let me know.
I don't think the zoomable library depends on ui-tooling, since ui-tooling is only used in the app module.
How should I deal with this?

@amrfarid140
Copy link

amrfarid140 commented Mar 11, 2024

It's mainly build system changes. Mostly going to be on the gradle build files and publishing. A good start is adding the kotlin multiplatform gradle plugin and moving all of the library code to commonMain.

You might hit an issue with @FloatRange annotations if they aren't a KMP module. I've successfully used your project in a Compose multiplatform project of mine. Can confirm it works in both iOS and Android.

@romainbsl
Copy link

@amrfarid140 You mean you forked it and change the build system, right?
Otherwise, I don't see how it could work on iOS side.

@amrfarid140
Copy link

Yes @romainbsl that's what I meant.

@romainbsl
Copy link

@usuiat I probably can help providing Compose Multiplatform support. I'll prepare a PR

@usuiat
Copy link
Owner

usuiat commented Mar 19, 2024

@romainbsl Thank you! I'm looking forward it.

@szczepanski-k
Copy link

Is there any progress in this subject?

@usuiat
Copy link
Owner

usuiat commented May 30, 2024

@szczepanski-k
I have released v2.0.0-beta01 that supports iOS.
https://github.com/usuiat/Zoomable/releases/tag/v2.0.0-beta01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants