Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Restoration #160

Open
T8RIN opened this issue Jan 14, 2024 · 1 comment
Open

State Restoration #160

T8RIN opened this issue Jan 14, 2024 · 1 comment

Comments

@T8RIN
Copy link

T8RIN commented Jan 14, 2024

add rememberSaveable instead of remember and option to control it

@usuiat
Copy link
Owner

usuiat commented Mar 8, 2024

Zoomable intentionally does not use rememberSaveable.
This is because I believe that zooming an image is a temporary operation that depends on the screen configuration, and therefore it is better not to save the state.
Using rememberSaveable will save the zoom state even when the screen size changes, but if the screen size changes, the optimal zoom scale should also change.
Therefore, I dare not use rememberSaveable and return to the default scale when the screen size changes.

Of course, this is my opinion.
If you have a reason why I should use rememberSaveable, please let me know.
Anyone's opinion is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants