Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp release to include Fonts folder #38

Closed
juliaelman opened this issue Aug 26, 2016 · 2 comments
Closed

Update gulp release to include Fonts folder #38

juliaelman opened this issue Aug 26, 2016 · 2 comments

Comments

@juliaelman
Copy link
Contributor

juliaelman commented Aug 26, 2016

The current gulp release task does not include the Fonts folder. We need to update this task to include this folder so that users are provided all of the assets they might need to make these files work correctly for their chosen application.

Refs #37

@juliaelman juliaelman modified the milestone: v1.0 Dec 22, 2016
@juliaelman juliaelman modified the milestone: v1.0 Feb 13, 2017
@yowill yowill modified the milestone: Tortilla Chip Day Sprint Feb 13, 2017
@shawnbot shawnbot self-assigned this Feb 14, 2017
@shawnbot
Copy link
Contributor

I took a stab at this last night and had a hard time because it wasn't clear (without switching between branches and running gulp release) what the structure of the resulting zips is supposed to be. We have smoke tests for files in the repo, but none for what the zips should produce. 😢

@juliaelman
Copy link
Contributor Author

@shawnbot from what I understand about this issue, we are just looking to include the Fonts folder with the assets. Here is an example of what the output folder structure might look like:

  uswds-assets-ai/
  ├── Colors/
  │   └── web-design-standards-colors.ase
  ├── Components/
  │   ├── Components_sticker_sheet.ai
  │   └── Components_sticker_sheet.pdf
  ├── CONTRIBUTUNG.md
  ├── Fonts/
  │   ├── Font_Awesome.zip
  │   ├── Merriweather.zip
  │   └── Source_Sans_Pro.zip
  ├── LICENSE.md
  └── README.md

I think I found the problem. We currently have the path for the font folder set incorrectly. It should just be Fonts. We should also exclude the config folder here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants