Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box-sizing should be set in the layout grid package #2899

Closed
thisisdano opened this issue Jan 31, 2019 · 1 comment
Closed

box-sizing should be set in the layout grid package #2899

thisisdano opened this issue Jan 31, 2019 · 1 comment
Assignees
@thisisdano
Labels
Type: Bug A problem in the code

Comments

@thisisdano
Copy link
Member

thisisdano commented Jan 31, 2019 •
edited

If folks include the USWDS layout grid package without also including the components package, the layout grid will not work properly since the box model will not default to border-box.

Since the layout grid uses box-sizing: border-box to calculate its sizing, we should add that css in the layout grid package (scoped to grid css) in addition to the rule(s) the components module.
@thisisdano thisisdano added Type: Bug A problem in the code 2.0 labels Jan 31, 2019
@thisisdano thisisdano self-assigned this Jan 31, 2019
@thisisdano thisisdano mentioned this issue Feb 1, 2019
Merged
@thisisdano
Copy link
Member Author

Fixed in #2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
Type: Bug A problem in the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thisisdano