Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search component should have its ARIA role in the <form> element #3344

Closed
thisisdano opened this issue Mar 5, 2020 · 1 comment
Closed

Search component should have its ARIA role in the <form> element #3344

thisisdano opened this issue Mar 5, 2020 · 1 comment
Assignees
@thisisdano
Projects
USWDS Sprint Board
Milestone
March 2020 Monthl...

Comments

@thisisdano
Copy link
Member

Let's not use a separate <div> for our role="search" markup. Each search variant should be consistent and put the ARIA role in the <form> element.
@thisisdano thisisdano self-assigned this Mar 5, 2020
@thisisdano thisisdano added this to the March 2020 Monthly Call milestone Mar 5, 2020
@thisisdano thisisdano mentioned this issue Mar 5, 2020
Merged
4 tasks
@thisisdano thisisdano added this to In progress in USWDS Sprint Board Apr 13, 2020
@thisisdano
Copy link
Member Author

Done in USWDS 2.6.0: 8b8d02f

USWDS Sprint Board automation moved this from In progress to Done Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisdano thisisdano

Labels
None yet
Projects
USWDS Sprint Board
  
Done
Milestone
March 2020 Monthly Call
Development

No branches or pull requests
1 participant
@thisisdano