Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile header overlay too dark. #4120

Closed
mejiaj opened this issue Mar 23, 2021 · 0 comments · Fixed by #4155
Closed

Mobile header overlay too dark. #4120

mejiaj opened this issue Mar 23, 2021 · 0 comments · Fixed by #4155
Assignees
@scottqueen-bixal
Labels
Type: Bug A problem in the code
Projects
USWDS Sprint Board
Milestone
2021: Bugs and on...

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Mar 23, 2021

Describe the bug

A change was made in 2.11.1 to darken the mobile menu overlay to match modal. Because it uses background and opacity the overlay is too dark.

Steps to reproduce the bug

  1. Go to header
  2. See dark background

Expected behavior

Background should be lighter.

Screenshots

image

System setup

  • USWDS version: 2.11.1
  • Device: Laptop
  • Operating system: Windows 10
  • Browser and version: Edge 89.0.774.57 | Firefox 88.0b1

Additional context

We should update the background to match overlay or lower opacity.
@mejiaj mejiaj added the Type: Bug A problem in the code label Mar 23, 2021
@mejiaj mejiaj added this to Bugs and ongoing work in USWDS Roadmap Backlog Apr 7, 2021
@mejiaj mejiaj added this to On-deck in USWDS Sprint Board Apr 7, 2021
@jAigret-Bix jAigret-Bix moved this from On-deck to Sprint backlog in USWDS Sprint Board Apr 13, 2021
@mejiaj mejiaj linked a pull request Apr 20, 2021 that will close this issue
USWDS | HEADER - Menu Toggle Background #4155
Merged
4 tasks
@mejiaj mejiaj moved this from Sprint backlog to Development review in USWDS Sprint Board Apr 20, 2021
@mejiaj mejiaj moved this from Development review to Fed final review in USWDS Sprint Board May 14, 2021
USWDS Sprint Board automation moved this from Fed final review to Done May 24, 2021
@jAigret-Bix jAigret-Bix removed this from Bugs and ongoing work in USWDS Roadmap Backlog Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottqueen-bixal scottqueen-bixal

Labels
Type: Bug A problem in the code
Projects
USWDS Sprint Board
  
Done
Milestone
2021: Bugs and ongoing work
Development

Successfully merging a pull request may close this issue.

USWDS | HEADER - Menu Toggle Background uswds/uswds
3 participants
@mejiaj @scottqueen-bixal @jAigret-Bix