Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog to PR checklist #5175

Closed
mejiaj opened this issue Mar 10, 2023 · 1 comment · Fixed by #5176
Closed

Add changelog to PR checklist #5175

mejiaj opened this issue Mar 10, 2023 · 1 comment · Fixed by #5176
Assignees
@mejiaj
Labels
Added during Sprint Affects: Documentation Relates to documentation. Should this be in uswds-site? Type: Enhancement An improvement to existing code

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Mar 10, 2023

We should add a checklist item to PR template that includes changelog updates on documentation for every related feature.
@mejiaj mejiaj added Added during Sprint Affects: Documentation Relates to documentation. Should this be in uswds-site? Type: Enhancement An improvement to existing code labels Mar 10, 2023
@mejiaj mejiaj self-assigned this Mar 10, 2023
@mejiaj mejiaj linked a pull request Mar 10, 2023 that will close this issue
PR Template: Add checklist item for changelog #5176
Merged
@mejiaj mejiaj mentioned this issue Mar 10, 2023
Merged
@thisisdano thisisdano linked a pull request Mar 20, 2023 that will close this issue
USWDS-Site - Settings: Fix code audit issues uswds/uswds-site#2016
Merged
@thisisdano thisisdano removed a link to a pull request Mar 20, 2023
USWDS-Site - Settings: Fix code audit issues uswds/uswds-site#2016
Merged
@thisisdano
Copy link
Member

I'm hesitant to add a Site PR requirement to every USWDS PR, but I do think each PR should address the data required by the changelog — then we can add the changelog elements as part of the release process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejiaj mejiaj

Labels
Added during Sprint Affects: Documentation Relates to documentation. Should this be in uswds-site? Type: Enhancement An improvement to existing code
Projects
USWDS Core Project Data
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR Template: Add checklist item for changelog uswds/uswds
2 participants
@mejiaj @thisisdano