Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS - Date Picker: Provide helpful error feedback when incorrect format is entered. #5692

Closed
Tracked by #5534
mejiaj opened this issue Dec 21, 2023 · 4 comments
Closed
Tracked by #5534

USWDS - Date Picker: Provide helpful error feedback when incorrect format is entered. #5692

mejiaj opened this issue Dec 21, 2023 · 4 comments
Labels
Affects: Accessibility 🟡 Relates to the accessibility of our components Package: Date Picker Role: Dev Development/engineering skills needed Severity: 1 🟡 Major functionality, no workaround Usability Testing Relates to usability testing fidings

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Dec 21, 2023 •
edited

Currently, users don't get any feedback that their input format is incorrect.
@mejiaj mejiaj mentioned this issue Dec 21, 2023
Open
3 tasks
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Dec 21, 2023
@mejiaj mejiaj added Package: Date Picker Role: Dev Development/engineering skills needed labels Dec 21, 2023
@brunerae brunerae added Needs: Discussion We need to discuss an approach to this issue and removed Status: Triage We're triaging this issue and grooming if necessary labels Dec 28, 2023
@jaclinec
Copy link

jaclinec commented Mar 3, 2024

@mejiaj the W3C design system offers some examples of form errors for dates that look promising:
image

We could try something similar to this, but if the user enters the wrong format the error message could say something like "Please enter a valid date format MM/DD/YYYY" or similar.

@jaclinec jaclinec added Severity: 1 🟡 Major functionality, no workaround Affects: Accessibility 🟡 Relates to the accessibility of our components Usability Testing Relates to usability testing fidings labels Mar 3, 2024
@mejiaj
Copy link
Contributor Author

mejiaj commented May 21, 2024

This issue is scoped to only USA Date Picker.

Work in #5879 shows that Date Picker component does have an error state that can be set.

Preview link →

@jaclinec @mahoneycm would you consider this issue to be valid or can we close it?

@jaclinec
Copy link

@mejiaj I think that the work in #5879 resolves this issue, so this can one can be closed.

@mejiaj mejiaj removed the Needs: Discussion We need to discuss an approach to this issue label May 21, 2024
@mejiaj
Copy link
Contributor Author

mejiaj commented May 21, 2024

Great, thanks for that update!

@mejiaj mejiaj closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Accessibility 🟡 Relates to the accessibility of our components Package: Date Picker Role: Dev Development/engineering skills needed Severity: 1 🟡 Major functionality, no workaround Usability Testing Relates to usability testing fidings
Projects
USWDS Core Project Data
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mejiaj @brunerae @jaclinec