Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS - Bug: Aspect utilities are always output even when excluded from settings #5934

Open
2 tasks done
aduth opened this issue May 21, 2024 · 1 comment · May be fixed by #5699
Open
2 tasks done

USWDS - Bug: Aspect utilities are always output even when excluded from settings #5934

aduth opened this issue May 21, 2024 · 1 comment · May be fixed by #5699
Labels
Needs: Confirmation We need to confirm that this is an issue Type: Bug A problem in the code

Comments

@aduth
Copy link
Contributor

aduth commented May 21, 2024

Describe the bug

When using the $output-these-utilities setting to control utilities which are included in the built stylesheet, the add-aspect utilities are always included, even when not listed in the setting.

Steps to reproduce the bug

Example stylesheet:

@forward "uswds-core" with (
  $output-these-utilities: ()
);

@forward "uswds-utilities";

Compiling the above will produce a stylesheet with 148 lines of .add-aspect- utility styles.

Expected Behavior

Nothing is output, since the setting is configured to include no utilities, and only the utilities package is forwarded.

Related code

See above.

Screenshots

No response

System setup

  • USWDS version: 3.8.0

Additional context

No response

Code of Conduct

@aduth aduth added Needs: Confirmation We need to confirm that this is an issue Type: Bug A problem in the code labels May 21, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label May 21, 2024
@aduth
Copy link
Contributor Author

aduth commented May 21, 2024

Apparently I had already submitted a pull request for this which I had forgotten about, and re-encountered the bug again today. I'll keep this open, since I assume it's best practice to have a related issue for each pull request.

@aduth aduth changed the title USWDS - Bug: Aspect utilities are always included even when excluded from settings USWDS - Bug: Aspect utilities are always output even when excluded from settings May 21, 2024
@mejiaj mejiaj removed the Status: Triage We're triaging this issue and grooming if necessary label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Confirmation We need to confirm that this is an issue Type: Bug A problem in the code
Projects
Status: Ready to Schedule
Development

Successfully merging a pull request may close this issue.

2 participants