Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ComGS classes to deal with multiple antennas, frequencies, and modulation types #4

Closed
200km opened this issue Jan 4, 2022 · 2 comments
Labels
minor update add functionality in a backwards compatible manner priority::medium priority medium simulation simulation settings

Comments

@200km
Copy link
Member

200km commented Jan 4, 2022

Overview

Improve ComGS classes to deal with multiple antennas, frequencies, and modulation types.

Details

  • To deal with multiple antennas
    • Need to have position and direction information in vector type like other components.
    • Need to select adequate Rx antenna responds to spacecraft attitude
  • To deal with multiple frequencies(S/X, up/down)
    • Implementation for up/down frequencies is easy.
      • Change ANT member variable frequency_ to tx_frequency_ and rx_frequency_ and add some programs.
    • Which components should have information about frequencies?
      • Making the TRP class and leaving the info for this class is good?
      • But how to have consistency with the current XTRP class?
    • How to check frequency matching with TX and RX antennas?
  • To deal with multiple modulation types
    • Modulation type, BER, coding type are now constants by implicit assumptions but should be variables.
    • It is required if users want to use this S/W to simulate both S and X bands.

Conditions for close

When the new ComGS class is implemented.

Supplement

N/A

Note

  • Write a conclusion when closing the issue.
@200km 200km added the priority::medium priority medium label Jan 4, 2022
@200km 200km added this to To do in S2E Apr 14, 2022
@200km 200km added simulation simulation settings minor update add functionality in a backwards compatible manner labels Nov 22, 2022
@200km
Copy link
Member Author

200km commented Dec 31, 2022

このissueもう終わっている気がするので、一旦整理

Need to have position and direction information in vector type like other components.

搭載方向情報は実装済み。
位置情報はGNSSアンテナには重要だが、通信用アンテナでは現時点では重要でない気がする。将来GNSSアンテナと通信アンテナが統合されることがある時に考えれば良さそう?

Need to select adequate Rx antenna responds to spacecraft attitude

選択するのは、搭載アルゴリズムなどがやることなのでS2Eの担当範囲ではないので、実装しないで良さそう

Change ANT member variable frequency_ to tx_frequency_ and rx_frequency_ and add some programs.

これは既に実装済み

Which components should have information about frequencies?

現時点ではAntennaクラスが周波数情報を持っている

Making the TRP class and leaving the info for this class is good?

TRPクラスは作ったほうが良さそう

How to check frequency matching with TX and RX antennas?

これはいまいち意図が分からない

Modulation type, BER, coding type are now constants by implicit assumptions but should be variables.

これは途中で使う変調方式などを変える場合に必要。別のissueで設けるので良さそう。

It is required if users want to use this S/W to simulate both S and X bands.

一応今もS/Xを併用できはする。

@200km
Copy link
Member Author

200km commented Dec 31, 2022

ということで、一旦これは閉じて変調方式を制御できるようにするissueをたてる

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor update add functionality in a backwards compatible manner priority::medium priority medium simulation simulation settings
Projects
None yet
Development

No branches or pull requests

1 participant