Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let pick a charset when generating code coverage html report #775

Closed
alesana-san opened this issue Nov 2, 2018 · 7 comments
Closed

Let pick a charset when generating code coverage html report #775

alesana-san opened this issue Nov 2, 2018 · 7 comments
Milestone

Comments

@alesana-san
Copy link

In version 3.1.2 there's a hardcoded value UTF8 for this kind of report. In case if you have some stuff in a different encoding (ex. Windows-1251), then all national symbols become unreadable

@jgebal
Copy link
Member

jgebal commented Nov 3, 2018

Can you provide an example with following information:

  • Database NLS character set
  • session NLS character set

We have a solution for XML reports already so i think the same should work for HTML (when we add it).

I guess that we should give the report back to user in user NLS character set.
To confitm that thos would work, can you set your session NLS to UTF8 ans see if the saved report shows proper characters in browser?

@jgebal
Copy link
Member

jgebal commented Nov 6, 2018

@alesana-san
Can you let me know what is your DB character set?

@alesana-san
Copy link
Author

@jgebal
Sorry for being late, will try described steps in a couple of days.
DB charset is CL8ISO8859P5
Actually I don't know if my case counts because I ran ut.run and then saved the output from PL/SQL Developer to file. Maybe source code was affected somehow during the saving process.

@alesana-san
Copy link
Author

@jgebal
Finally made a report using CLI and everything was OK. CLI put this line:

So I guess the issue can be closed.

@jgebal
Copy link
Member

jgebal commented Nov 7, 2018

@pesse
Is cli replacing / adding charset to html report automatically? I thought it was to be provided from framework.

@pesse
Copy link
Member

pesse commented Nov 8, 2018

CLI is providing charset based on Java locale (not sure - have to verify). Framework is not necessarily able to auto-detect the charset needed.

@jgebal
Copy link
Member

jgebal commented Nov 18, 2018

Checked. Client encoding is already passed to HTML coverage report when client application provides encoding.

Will update documentation to mention character-set setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants