Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely get rid of protobuf #62

Closed
yuhc opened this issue Jan 25, 2021 · 1 comment · Fixed by #64
Closed

Completely get rid of protobuf #62

yuhc opened this issue Jan 25, 2021 · 1 comment · Fixed by #64
Assignees
@yuhc
Labels
refactor Make code more beautiful
Milestone
Fix specs and man...

Comments

@yuhc
Copy link
Member

yuhc commented Jan 25, 2021

When the guestlib and TensorFlow link against two different versions of libprotobuf, the guestlib loaded by a TensorFlow program will fail to initialize.

A recent PR #61 removes the depedency of protobuf completely. But due to the time limit, I didn't get to remove deprecated files.
@yuhc yuhc added the refactor Make code more beautiful label Jan 25, 2021
@yuhc yuhc added this to the Fix specs and manager milestone Jan 25, 2021
@yuhc yuhc self-assigned this Jan 25, 2021
@yuhc
Copy link
Member Author

yuhc commented Jan 25, 2021

Reminder: also update the dependency installation script.

@yuhc yuhc linked a pull request Jan 26, 2021 that will close this issue
Remove Protobuf dependency #64
Merged
@yuhc yuhc closed this as completed in #64 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuhc yuhc

Labels
refactor Make code more beautiful
Projects
None yet
Milestone
Fix specs and manager
Development

Successfully merging a pull request may close this issue.

Remove Protobuf dependency yuhc/ava
1 participant
@yuhc