Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

103 windows build #23

Closed
wants to merge 41 commits into from
Closed

103 windows build #23

wants to merge 41 commits into from

Conversation

rcrowder
Copy link

My Travis account managed to run the Linux version only - https://travis-ci.org/rcrowder/nupic.core
It looks like a successful run?

I used the GUI version of CPPCheck built from source.Not all the style advice was taken.

Is it worth pursuing the path of MinGW cross compilation on Travis?
https://travis-ci.org/rcrowder/travis-ci-test

Encouragingly not too many changes to be made. Locally built CPPCheck
with QT GUI. Will look at adding to Travis/AppVeyor build at some point.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling 92d6082 on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@rcrowder
Copy link
Author

@rhyolight Thank you for the advice that has worked a treat. Getting the hang of this Git after years within Perforce, and way back Visual Source Safe :)

@rhyolight
Copy link
Collaborator

@rcrowder Nice. Yes the OS X builds are still a "beta" feature that needs to be requested from support@travis-ci.com. Tell them the URL of your fork and they will turn it on for you. In the meantime, don't worry about it. Once it merges into the main PR, the OS X build will run.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.56%) when pulling 7f8139a on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) when pulling be39ccc on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.02%) when pulling 12a678e on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling f772a7c on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.74%) when pulling 958ec2a on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.17%) when pulling 5e97e3c on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.13%) when pulling 9ef7257 on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.62%) when pulling f2acf01 on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.74%) when pulling fb119e7 on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) when pulling aed0950 on rcrowder:103-windows-build into d4eb68e on utensil:103-windows-build.

@rcrowder
Copy link
Author

https://ci.appveyor.com/project/rcrowder/nupic-core/build/1.0.37
All projects compiled and linked. Tests running through to completion. Now need to compare with the GCC and CLANG build output, see if those passing test cases are actually passing :)

@rhyolight
Copy link
Collaborator

Nice progress, @rcrowder!

@rcrowder
Copy link
Author

@rhyolight Thank you. It's shaping up. I'm just updating the task list..

@rcrowder
Copy link
Author

Green lights! https://github.com/rcrowder/nupic.core/tree/103-windows-build
Next step is to transfer my AppVeyor Web UI settings to the .yml file...

@utensil
Copy link
Collaborator

utensil commented Sep 15, 2014

@rcrowder Great work!

The reason why it's all red is only because this is a PR to my branch, and my AppVeyor settings preventing them to succeed.

As numenta#161 is merged by @rhyolight as suggested here, you have a clean start, so you do not have to PR to my branch and may directly PR to numenta:master. Just go to rcrowder/nupic.core@numenta:master...103-windows-build and create the direct PR then you would have green builds. You would also need to pull from numenta:master and resolve conflicts.

@rcrowder
Copy link
Author

Thank you. Getting closer :)

And thank you for the comparison link. It looks quite easy to create a new PR, although unsure what happens to the existing one and files store locally. Will backup and try and create a new PR to see what happens. Hopefully it is straight forward and doesn't need messy reverting? if the new PR is setup wrong.

@rhyolight Any final words of wisdom before this PR gets replaced with one straight off of master?

@david-ragazzi
Copy link

Getting closer :)

I look forward for NuPIC comunnity (including me) is able to code Nupic C++ on Windows and Visual Studio finally! Productivy certainly will increase! Great job, @rcrowder !

By the way, I'm not sure if NuPIC Python also could be compiled with VS because I'm not familiar with bindings c++ code.. The next step is that!

@utensil
Copy link
Collaborator

utensil commented Sep 15, 2014

It looks quite easy to create a new PR, although unsure what happens to the existing one and files store locally. Will backup and try and create a new PR to see what happens. Hopefully it is straight forward and doesn't need messy reverting? if the new PR is setup wrong.

PR is based on the feature branch, namely https://github.com/rcrowder/nupic.core/tree/103-windows-build . One can create multiple PRs based on one branch to different branches( in your case, utensil:103-windows-build, numenta:master), and the contents on that branch won't be affected, only the destination has been changed.

So, no worries!

@rcrowder
Copy link
Author

Excellent, thanks @utensil I went as far as pushing the final button. Knew it would be easy. Need word from @rhyolight , then good to go..

Indeed @Davidragazzi , it is nice. I have it all setup in 2013 (v120), including the external libraries. I had to go through the Debug version to catch a few things (such as, missing platform specific code).

Lots of new information to add to the wiki about the build process and some important Git usage lessons learned. A very nice development environment evolving.

Once this PR is wrapped. Help sort out NuPIC for Windows, find a PyCharm project for NuPIC, Qt running on RaspberryPi, ... :)

@rhyolight
Copy link
Collaborator

@rcrowder Go for it! Once the new PR is created, you can close this one, although you might want to reference it from the new one.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.35%) when pulling 0e06ee6 on rcrowder:103-windows-build into 38dee89 on utensil:103-windows-build.

@rhyolight
Copy link
Collaborator

Closing this in favor of numenta#184.

@rhyolight rhyolight closed this Sep 15, 2014
utensil pushed a commit that referenced this pull request Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants