Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded test framework to version compatible with latest nightlies. #50

Closed
wants to merge 1 commit into from

Conversation

gilescope
Copy link

Added example of how to just get the plain text from a webpage.
(E.g. for machine learning sometimes you just want access to plain text).

If there's a neater way to do it, I'd love to see it - I couldn't find a specific root node function on document? Did I miss one, if not it would be nice to call it out as a specific function rather than nth(0).

Added example of how to just get the plain text from a webpage.
@utkarshkukreti
Copy link
Owner

Thanks for the PR!

Node::text() already exists but it doesn't remove script / noscript elements. Is this why you're building your own function? In any case, I don't think this is an example worth having in this repository.

I agree about .nth(0); we should have a Document::root() which returns Node (not Option<Node> since nth(0) will always succeed).

@utkarshkukreti
Copy link
Owner

speculate has been updated to 0.1.2 in #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants