Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove React Player and use plyr-react library for sound #54

Closed
Utkarshn10 opened this issue Feb 11, 2023 · 12 comments
Closed

Remove React Player and use plyr-react library for sound #54

Utkarshn10 opened this issue Feb 11, 2023 · 12 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers

Comments

@Utkarshn10
Copy link
Owner

No description provided.

@Utkarshn10 Utkarshn10 self-assigned this Feb 11, 2023
@Utkarshn10 Utkarshn10 added the dependencies Pull requests that update a dependency file label Feb 11, 2023
@Utkarshn10 Utkarshn10 removed their assignment Feb 12, 2023
@Utkarshn10 Utkarshn10 added the good first issue Good for newcomers label Feb 12, 2023
@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 Hi I would like to contribute.

@Utkarshn10
Copy link
Owner Author

Issue assigned. @Abhishek7Tech please go ahead.

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 On it!

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 Just tried out plyr-react library.

I don't know if it supports mp3 or audio as all examples uses video.
What other features the library has isn't documented well.

If you have other documentation references, please share.

@Utkarshn10
Copy link
Owner Author

Utkarshn10 commented Feb 14, 2023 •
edited
Loading

If that's the case then React AudioPlayer is also good. You can go ahead with it.

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 On it!

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 Hi Just tried out React AudioPlay.

Sound only plays when I pass the control like this-

Screenshot (56)

@Abhishek7Tech
Copy link
Contributor

Without it sound does not play, and the green button becomes useless.

@Utkarshn10
Copy link
Owner Author

It would be great if we keep the current design as it is. Are there any other good options for libraries that we can use? react-h5-audio-player can also be a choice. But would love to know your thoughts on it.

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 Personally I would have kept the current design as it works good. If you want I can try out react-h5-audio-player as well.

Let me know if you want me to try this new library as well.

@Utkarshn10
Copy link
Owner Author

Lets keep the current design for now. Thanks @Abhishek7Tech for contributing.

@Abhishek7Tech
Copy link
Contributor

@Utkarshn10 Welcome. Please close the issue...

@Abhishek7Tech Abhishek7Tech removed their assignment Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Utkarshn10 @Abhishek7Tech