Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Typography styles might be too general #99

Open
MichaelAllenWarner opened this issue Sep 8, 2022 · 1 comment
Open

Some Typography styles might be too general #99

MichaelAllenWarner opened this issue Sep 8, 2022 · 1 comment
Assignees

Comments

@MichaelAllenWarner
Copy link
Contributor

Some of these base-element rules may be more general than intended. The reason I think so is the following discrepancy I'm seeing between accordions previewed in WordPress and accordions in Storybook (from my local branch, where I'm integrating React-Bootstrap):

Screen Shot 2022-09-08 at 2 43 56 PM

Screen Shot 2022-09-08 at 3 06 32 PM

I've traced the discrepancy to the h2 top-margin rule in the Next.js app, which—judging by what I'm seeing in WordPress—doesn't seem to have a direct counterpart in the framework. When I nix that rule in the dev-tools in Storybook, the accordion looks right.

@spworky
Copy link
Collaborator

spworky commented Sep 8, 2022

Yes, I am aware of the margin issue. I added generic margins to the main headers, and have not yet trickled that down through the rest of the site. Definitely needs to be looked at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants