Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Makefile #15

Closed
ashmrtn opened this issue Jul 28, 2017 · 6 comments
Closed

Redo Makefile #15

ashmrtn opened this issue Jul 28, 2017 · 6 comments
Assignees

Comments

@ashmrtn
Copy link
Member

ashmrtn commented Jul 28, 2017

Now that the project is getting bigger, the Makefile should be modified so that builds are cleaner.

Included code should be compiled into libraries where possible and linked where needed instead of provided directly as it is now.

Compiled code should also be placed in its own build directory instead of alongside the source files which generated it. This will make make clean much easier to define as well as making it easier to avoid checking in binaries in git.

@ashmrtn ashmrtn self-assigned this Jul 28, 2017
@vijay03
Copy link
Member

vijay03 commented Aug 30, 2017

@ashmrtn , is this done, should we close this issue?

@ashmrtn
Copy link
Member Author

ashmrtn commented Aug 30, 2017

I am hesitant to call it finished. I would really like to switch to something like CMake or Bazel (though Bazel unfortunately has a Java dependency). That way it's a little less cryptic (at least that is my hope). I have kind of been switching stuff over to "cleaner" Make statements, although they are regrettably much more cryptic than the ones that existed before them.

@vijay03
Copy link
Member

vijay03 commented Aug 30, 2017

My personal opinion is that your current Makefile is fine :) We should definitely not use anything related to Java, and I often CMake makes things harder to understand, not easier.

@ashmrtn
Copy link
Member Author

ashmrtn commented Aug 30, 2017

That's kind of a shame, I had hoped there would be something that would provide a rather readable build file. Anyway, I guess we should kind of shuffle the remaining items over to build in the build directory. Some of the variables/target names may need a bit of cleaning up too, now that I think of it.

@vijay03
Copy link
Member

vijay03 commented Aug 30, 2017

Alright, do you want to handle it yourself? It might be a good warm-up task for Sonika.

@ashmrtn
Copy link
Member Author

ashmrtn commented Aug 30, 2017

I can pick up this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants