Should github-dark theme match official Github Dark mode?

[rpetit3]

Hello!

I was curious to get your thouts on the "github-dark" theme. Currently it doesn't match the official GitHub Dark mode colors.

Do you think the "github-dark" them should be updated or a new them added?

Thank you!

[jdanyow]

For sure, just waiting on the next primer update

[rpetit3]

Is this something that will be automatically updated (e.g. Primer provides it) or will the color codes need to be changed here?

I ask because I'm testing locally and modified the github-dark theme to match the current Github Dark Mode. I can submit a PR if you want either as a separate theme or updated github-dark.

Thanks!

[jdanyow]

Utterances uses standard primer for the GitHub light theme, then a modified primer for the rest of the themes, including GitHub dark. Mostly variable changes. Once GitHub ships a new version of primer with all the css custom property and dark theme work, I’ll update utterances to use it.

[rpetit3]

Hi @jdanyow

Would it be possible to get your input on #463 ?

Thank you very much!