Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self code review season 2 #62

Open
utubo opened this issue Mar 11, 2020 · 2 comments
Open

Self code review season 2 #62

utubo opened this issue Mar 11, 2020 · 2 comments

Comments

@utubo
Copy link
Owner

utubo commented Mar 11, 2020

Season 1 -> #24

@utubo
Copy link
Owner Author

utubo commented Mar 11, 2020

  • カスタムジェスチャでexecuteScriptの結果がstructured-clonableでない場合の処理がベッタベタなのでなんとかしたい…
    background.js
e.message.indexOf('result is non-structured-clonable data') === -1 // Ignore invalid value.

その他の例外との比較(log)

e.fileName: resource://gre/modules/ExtensionContent.jsm →alertしたい例外(syntax errorもこっち)
e.fileName: <anonymous code> →問題の例外(他にもこっちになるのがあるかも?)

もっとしっかりした切り分けはないのか

Originally posted by @utubo in #24 (comment)

@utubo
Copy link
Owner Author

utubo commented Mar 11, 2020

  • options.jsが全体的にひどい整理したい…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant