Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the search terms in the results #40

Closed
jgonggrijp opened this issue Aug 29, 2017 · 2 comments
Closed

Highlight the search terms in the results #40

jgonggrijp opened this issue Aug 29, 2017 · 2 comments
Assignees
Labels
enhancement improvements to user functionality

Comments

@jgonggrijp
Copy link
Member

Either using Alto (but this only makes sense if we also show the scanned image, which we don't do yet) or by applying a quick client-side search on the plain text (as suggested by @oktaal).

@jgonggrijp jgonggrijp added the enhancement improvements to user functionality label Aug 29, 2017
@jgonggrijp jgonggrijp added this to the First visualisations milestone Aug 29, 2017
@oktaal oktaal self-assigned this Oct 23, 2017
@oktaal
Copy link
Member

oktaal commented Oct 23, 2017

@JosedeKruif mentioned that similar functionality was already built for https://github.com/UUDigitalHumanitieslab/LoCMiner. So I'll look into that first.

@oktaal
Copy link
Member

oktaal commented Oct 23, 2017

The highlighting is added by the LoC API, so this cannot be reused for this.

This was referenced Oct 25, 2017
oktaal added a commit that referenced this issue Oct 26, 2017
@oktaal oktaal closed this as completed in 66d143a Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to user functionality
Projects
None yet
Development

No branches or pull requests

2 participants