Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tee: Remove deprecated retain_mut dependency when MSRV is >= 1.61.0 #4190

Closed
oliviacrain opened this issue Nov 28, 2022 · 4 comments
Closed
Labels

Comments

@oliviacrain
Copy link

The retain_mut crate is a dependency of the uu_tee crate. The functionality provided by retain_mut was stabilized in the standard library earlier this year in the 1.61.0 release. As a result, the maintainer of retain_mut has marked the crate as deprecated and no longer maintains it.

We should remove the dependency and use the standard library's functionality in uu_tee crate once we bump the MSRV to 1.61.0 or later. I don't think this presents a pressing reason to raise the MSRV. This is just a reminder to remove the dependency when the time comes.

@jfinkels
Copy link
Collaborator

Related to #3555

@tertsdiepraam
Copy link
Member

Yeah, we can probably do this after the next release, which is when we usually bump MSRV. Thanks for making an issue for it!

@cakebaker
Copy link
Contributor

This ticket can be closed, it has been implemented in bf8e933 .

@tertsdiepraam
Copy link
Member

Indeed! I forgot that we also had an issue for it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants