New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uucore
: put more deps behind feature flags (for nushell)
#5202
Comments
uucore
: put more deps behind feature flagsuucore
: put more deps behind feature flags (for nushell)
Is there more work necessary for this ticket to be considered as "done" or can I close it? |
is it possible to add a check in the CI to make sure we don't regress? |
@sylvestre there's #4032 or do you mean something else? |
@cakebaker I'm happy with this! The only thing "missing" is that clap is still required, but that is a larger issue and covered by the "compile cp without clap" issue. Thanks for working on this! |
Context: nushell/nushell#10097 (comment)
uucore
is quite modular in that large parts can be enabled or disabled via features. However, this does go far enough yet. There are many modules in the mods folder, that should be put behind feature flags.This would make it so that
uucore
becomes smaller and faster to compile when only compiling a subset of utils. This is of particular interest for nushell, where we are introducing just a single util (cp
), but have to include the entirety ofuucore
.Fixing this should not be too hard. However, we should pay special attention to verify that every util still compiles on its own. That is, that they individually enable all the features they need. Every util should compile like this:
Ideally, we would also test this in the CI. See also #4032
PS: Ultimately, I think
uucore
should be split into multiple crates, but that's an issue for another time. If we make it more modular now, we can also more easily split it up in the future.The text was updated successfully, but these errors were encountered: