Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mktemp: expose functionality for nushell #5465

Closed
tskinn opened this issue Oct 28, 2023 · 2 comments · Fixed by #5479
Closed

mktemp: expose functionality for nushell #5465

tskinn opened this issue Oct 28, 2023 · 2 comments · Fixed by #5479

Comments

@tskinn
Copy link
Contributor

tskinn commented Oct 28, 2023

As per #5088 (comment) I'm opening this ticket to discuss details about how expose mktemp functionality for use in nushell.

@tskinn
Copy link
Contributor Author

tskinn commented Oct 28, 2023

Should a new pub fn be created that returns a result of String as I think the current functions just print to stdout. What other considerations are there?

@tertsdiepraam
Copy link
Member

Yes, I think that's a good idea! I think it should be roughly done as follows:

  • mktemp: returns a path and calls exec and dry_exec
  • exec and dry_exec should also return the path.
  • uumain calls mktemp and prints the result.

Otherwise I think this one should be fairly simple. Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants