Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bs4 requirement for login_info #6

Closed
wants to merge 2 commits into from
Closed

Removed bs4 requirement for login_info #6

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2020

Replaced bs4 tree select for finding login info with re and a function to parse returned data from response text. Not sure if this will allow for Alarm.com to be integrated back into HA or if this still would be flagged as 'web scraping'. I have tested on my HA install and believe everything to be in working order.

@uvjustin
Copy link
Collaborator

Thanks for the PR, but I would think this is still considered web scraping by HA (we're still accessing the interface via an unpublished API). I am agnostic on whether to use bs4 or re, but I don't think it's worth a version bump if it doesn't resolve anything. Thoughts? @aechelon

@aechelon
Copy link

I tend to agree with @uvjustin. I can appreciate the sentiment behind the HA folks deprecating the official module -- so long as there's no official ADC API the impl is going to be completely reliant on ADC keeping the web interface unchanged. Also, the bs4 impl would likely be easier to update if ADC decides to make more significant or structural changes to the web interface at some later point (which, from what we've seen thus far is almost guaranteed).

@ghost
Copy link
Author

ghost commented Mar 25, 2020

I was having problems finding what HA considered web scraping so this was a shot in the dark. If it truly means anything accessed via unpublished API then I don't see it making any difference using re unless it saves on overhead at all. To @aechelon point about maintaining, probably easier with bs4. On a side note, I'm really getting tired of companies not having open API's. Thanks!

@ghost ghost closed this Mar 25, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants