Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Style the Installer" and upgrade to Bootstrap 4? #26

Closed
KevSlashNull opened this issue Sep 30, 2017 · 3 comments
Closed

"Style the Installer" and upgrade to Bootstrap 4? #26

KevSlashNull opened this issue Sep 30, 2017 · 3 comments

Comments

@KevSlashNull
Copy link
Contributor

KevSlashNull commented Sep 30, 2017

Hey,

I first wanted to create a Flarum web installer on my own, but then I discovered this pockethold.

This link takes you to a video of my installer. I only coded two or three hours on it and it had some major issues like not beeing able to reload the tab or continue from a second device like pockethold is able to.

I still like the vertical timeline or at least some more visual feedback from what is happening. So I forked the repo and made the following changes.

  • Update to Bootstrap 4.0.0-beta
  • Add font-awesome (4.7.0)
  • Replace h2 and span to button with disabled attribute and a spinning font-awesome gear.
  • Add a progress bar for the Flarum installation
  • Add a <title>

And that looks like this. Code here.

What I want to say with this issue is that Pockethold, even in alpha, could get some love to it's style. Not exactly what I programmed, but not "only" text.

Aaand maybe upgrade to Bootstrap 4 even if it's in beta, it looks really cool to me compared with Boostrap 3.

KevSlashNull. ^-^

@andreherberth
Copy link
Member

Hi, thank you for showing interest in contributing to pockethold.

Your UI additions is most welcome, so I incite you to do a pull request.

I am also be interested in your vertical timeline approach.

If I visit the pockethold installer from another browser, it simply only check with the server what the current install status is, so it would be easy to "rebuild" the timeline based on status gotten from the server.

In your example, did you have any server side code yet? It would be interesting to see how you did the requirement checks.

@KevSlashNull
Copy link
Contributor Author

Hey,

I've created pull request #27.

Okay, I will try to implement the vertical timeline into pockethold the following days.

I have some server side code, but it's not that well-engineered yet. Just testing for Composer and PHP, I think.

@andreherberth
Copy link
Member

I have merged your #27 into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants