Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with Go 1.18 again #15

Closed
coder543 opened this issue Mar 15, 2022 · 3 comments · Fixed by #16
Closed

Fails with Go 1.18 again #15

coder543 opened this issue Mar 15, 2022 · 3 comments · Fixed by #16

Comments

@coder543
Copy link

It appears to be failing on blank lines in the output of go version -m. This is the complete output:

2022/03/15 12:49:04 failed to evaluate licenses: unrecognised line: 	
@coder543
Copy link
Author

the blank lines appear to be related to dependencies that have been replaced with a replace directive.

@nick-jones
Copy link
Contributor

nick-jones commented Mar 15, 2022

Thaks for the report.

the blank lines appear to be related to dependencies that have been replaced with a replace directive.

I think that's correct, yeah - I see the same thing when a replace directive is in use:

protoc-gen-bq-tablemap: go1.18rc1
        path    github.com/utilitywarehouse/***/cmd/protoc-gen-bq-tablemap
        mod     github.com/utilitywarehouse/***       (devel) 
        dep     github.com/golang/protobuf      v1.5.2  
        dep     github.com/lyft/protoc-gen-star v0.6.0
        =>      github.com/johanbrandhorst/protoc-gen-star      v0.4.16-0.20200806111151-9a8e34bf9dea   
        
        dep     github.com/spf13/afero  v1.8.0  
        dep     golang.org/x/text       v0.3.7  
        dep     google.golang.org/protobuf      v1.27.1 
        build   -compiler=gc
        build   CGO_ENABLED=1
        build   CGO_CFLAGS=
        build   CGO_CPPFLAGS=
        build   CGO_CXXFLAGS=
        build   CGO_LDFLAGS=
        build   GOARCH=amd64
        build   GOOS=linux
        build   GOAMD64=v1
        build   vcs=git
        build   vcs.revision=3364ba2acfdc67eddc2085e717b2f5c9980b22da
        build   vcs.time=2022-03-14T10:33:06Z
        build   vcs.modified=true

Trivial to fix, but I'm slightly curious around the circumstances that lead to this - I'll do a bit of digging.

@nick-jones
Copy link
Contributor

It looks like this might have been introduced in golang/go@765c911 - I suspect it wasn't intentional. Either way, I'll make a change to get it to skip blank lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants