REVIEW mb/fixElectrodeArray #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Jan 23, 2017
| # Traverse file list and look for `pattern` | ||
| filenames = [] | ||
| pattern = re.compile(pattern) | ||
| for file in listdir(datapath): |
There was a problem hiding this comment.
Please change file to be something that isn't a reserved name in Python (fname would work)
…hickness arithmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few improvements for the ElectrodeArray class and some helper functions. Most of these are already being used in my experiment branches in one form or the other, but are now also tested and integrated. So the purpose of their existence is mostly to make my life easier. 😸
Argus I arrays now support legacy naming (L1, L2, ..., L8, M1, M2, ..., M8).
The electrode-to-retina distance depends on electrode type and electrode location. This computation has been moved to
Electrode.set_heightso that heights can be overridden.Keeping track of electrode names in
ElectrodeArray.namesis redundant, because everyElectrodehas anameitself. Setting custom (or new) names would have to be done in both places, otherwise indexing might break. Therefore, I removedElectrodeArray.names. In order to do the indexing, the loop has to be overnameof everyElectrodein anElectrodeArray. In order to speed up the average lookup time, the array is traversed in random order.The parameter
tolofpulse2perceptnow specifies a fraction instead of an absolute value: For example,tol=0.1will discard all pixels whose effective current is <10% of the max effective current value.I also added a helper function that can find files in a directory whose names match a regular expression pattern.