New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the magic salt for column name conflicts #541

Open

shrjain opened this issue Sep 20, 2016 · 0 comments

Assignees

Labels

bug

shrjain commented Sep 20, 2016

Scheme object currently adds a salt (string '1') to disambiguate same column names.
This should be replaced with the following:

Update the add_attribute method to not add salt.
Add/Update the get_attribute method to throw a properly constructed exception message when there is a column name conflict.

Overall philosophy should be to let the user do the renames/aliasing and now have implicit fixes.

shrjain added the bug label

shrjain assigned shrjain and billhowe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment