Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy in MatMul Slides vs. Demo #9

Open
werrah opened this issue Apr 24, 2016 · 2 comments
Open

Discrepancy in MatMul Slides vs. Demo #9

werrah opened this issue Apr 24, 2016 · 2 comments
Labels

Comments

@werrah
Copy link

werrah commented Apr 24, 2016

In the Lecture 8 slides, the final line in MatMul is C[ i * N + j ] += A[ i * N +k ] * B[ k * N + j ]. That first and last N should be K, correct? In the demo, that line is changed to C[ K * i + j ] += A[ N * i +k ] * B[ K * k + j ]. When I was working it out by hand so it would make sense in my head, the demo code made sense, but the lecture slides didn't. Is that a mistake in the slides, or is there something I'm missing that would explain whey the two are different?

@cswiercz
Copy link
Member

cswiercz commented Apr 24, 2016

You are absolutely correct. There was a typo (two, in fact) in the lecture slides. I will upload a correction.

@cswiercz
Copy link
Member

Corrections uploaded. I will notify the class along with the quiz reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants