Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #11

Open
justaugustus opened this issue Dec 22, 2022 · 0 comments
Open

Add unit tests #11

justaugustus opened this issue Dec 22, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@justaugustus
Copy link
Contributor

justaugustus commented Dec 22, 2022

From @lgecse in #157:

Make testing possible with mocking the GH and Jira services. This would make the development faster, and safer.

From: coreos/issue-sync#47

Refactor for improved testability (in preparation for adding unit tests).

From: coreos/issue-sync#41

I'm looking to use this for github -> jira workflow integration. I'd like to add unit tests to ascertain stability and help justify using this open source project at my org. I'll be following up this issue with pull requests as I add unit tests. I'm opening this issue now to start discussion with anyone who's interested in providing feedback/suggestions.

I had a few questions I wanted to ask the maintainers of this project. I figured I would ask here. Could anyone fill me in on the current state of this project? Is it actively being used at CoreOS? How open to external contributions are you?

@\crfeliz this project was started two years ago and at the time we needed to use it because we were migrating our own issues to Jira. Since then, a lot changed for us at CoreOS including our workflows and as a result we are no longer actively using it. I’m maintaining the project but am not actively contributing. However, I would very gladly accept PRs from willing contributors.

@justaugustus justaugustus added the bug Something isn't working label Dec 22, 2022
@justaugustus justaugustus mentioned this issue Dec 22, 2022
8 tasks
@justaugustus justaugustus added this to the v.next milestone Dec 22, 2022
This was referenced Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants